Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uh_init: Handle safety around set_var #514

Merged
merged 3 commits into from
Dec 17, 2024
Merged

uh_init: Handle safety around set_var #514

merged 3 commits into from
Dec 17, 2024

Conversation

smalis-msft
Copy link
Contributor

Part of #288

@smalis-msft smalis-msft requested a review from a team as a code owner December 17, 2024 18:28
@jstarks
Copy link
Member

jstarks commented Dec 17, 2024

Can we fix this the right way, by having these env vars get set when we spawn processes, instead of just hacking around the new limitation?

@smalis-msft
Copy link
Contributor Author

It has the behavioral change of not modifying the environment for underhill_init itself, but that's probably fine?

@jstarks
Copy link
Member

jstarks commented Dec 17, 2024

Yeah, I think that should be OK.

@smalis-msft smalis-msft enabled auto-merge (squash) December 17, 2024 19:07
@smalis-msft smalis-msft merged commit b682370 into microsoft:main Dec 17, 2024
25 checks passed
@smmalis37 smmalis37 deleted the init-set-var branch December 21, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstarks jstarks jstarks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smalis-msft @jstarks