vmbus_async: don't panic on empty external data #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SvenGroot
reviewed
Jan 7, 2025
Merged
jstarks
reviewed
Jan 8, 2025
jstarks
reviewed
Jan 8, 2025
jstarks
reviewed
Jan 8, 2025
jstarks
changed the title
jstarks
reviewed
Jan 8, 2025
jstarks
reviewed
Jan 9, 2025
jstarks
reviewed
Jan 9, 2025
benhillis
added
the
backport_2411
benhillis
pushed a commit
to benhillis/openvmm
that referenced
this pull request
Feb 6, 2025
Don't `panic` when a GpaDirect packet contains a pointer to empty GPA ranges. This data is guest controlled and not a programmer error, so `panic` is not correct. Consumers of `read_external_ranges` already handle errors gracefully, so this is not a significant change for them. As a drive-by code improvement, also change some cases of `#[from]` to `#[source]` in error definitions, and add the requisite `.map_err` changes.
benhillis
pushed a commit
to benhillis/openvmm
that referenced
this pull request
Feb 7, 2025
Don't `panic` when a GpaDirect packet contains a pointer to empty GPA ranges. This data is guest controlled and not a programmer error, so `panic` is not correct. Consumers of `read_external_ranges` already handle errors gracefully, so this is not a significant change for them. As a drive-by code improvement, also change some cases of `#[from]` to `#[source]` in error definitions, and add the requisite `.map_err` changes.
benhillis
added a commit
that referenced
this pull request
Feb 7, 2025
Don't `panic` when a GpaDirect packet contains a pointer to empty GPA ranges. This data is guest controlled and not a programmer error, so `panic` is not correct. Consumers of `read_external_ranges` already handle errors gracefully, so this is not a significant change for them. As a drive-by code improvement, also change some cases of `#[from]` to `#[source]` in error definitions, and add the requisite `.map_err` changes. Co-authored-by: Matt Kurjanowicz <[email protected]>
|
Backported in #802 |
jstarks
added
backported_2411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't
panicwhen a GpaDirect packet contains a pointer to empty GPA ranges. This data is guest controlled and not a programmer error, sopanicis not correct. Consumers ofread_external_rangesalready handle errors gracefully, so this is not a significant change for them.As a drive-by code improvement, also change some cases of
#[from]to#[source]in error definitions, and add the requisite.map_errchanges.