Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hcl: fix multiple calls to flush_deferred_actions #739

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

jstarks
Copy link
Member

@jstarks jstarks commented Jan 29, 2025

Don't remove the deferred action list from TLS until the ProcessorRunner is actually dropped.

This fixes crashes after a failed servicing operation.

Don't remove the deferred action list from TLS until the
`ProcessorRunner` is actually dropped.

This fixes crashes after a failed servicing operation.
@jstarks jstarks requested a review from a team as a code owner January 29, 2025 20:45
@jstarks jstarks added the backport_2411 Change should be backported to the release/2411 branch label Jan 29, 2025
@smalis-msft
Copy link
Contributor

Could this be behind #71 ?

@jstarks jstarks merged commit a4c8d79 into microsoft:main Jan 31, 2025
25 checks passed
@jstarks jstarks deleted the fix_deferred branch January 31, 2025 17:44
jstarks added a commit to jstarks/openvmm that referenced this pull request Feb 7, 2025
Don't remove the deferred action list from TLS until the
`ProcessorRunner` is actually dropped.

This fixes crashes after a failed servicing operation.

Backport-of: microsoft#739
jstarks added a commit to jstarks/openvmm that referenced this pull request Feb 7, 2025
Don't remove the deferred action list from TLS until the
`ProcessorRunner` is actually dropped.

This fixes crashes after a failed servicing operation.

Backport-of: microsoft#739
jstarks added a commit that referenced this pull request Feb 8, 2025
Don't remove the deferred action list from TLS until the
`ProcessorRunner` is actually dropped.

This fixes crashes after a failed servicing operation.

Backport-of: #739
@jstarks
Copy link
Member Author

jstarks commented Feb 10, 2025

Backported in #822

@jstarks jstarks added backported_2411 PR that has been backported to release/2411 and removed backport_2411 Change should be backported to the release/2411 branch labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport_2411_approved backported_2411 PR that has been backported to release/2411
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants