New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add infrastructure to simulate the OpenHCL test failures #742

Merged

bhargavshah1988 merged 13 commits into microsoft:main from bhargavshah1988:bhsh_testFix

Jan 31, 2025

Contributor

bhargavshah1988 commented Jan 30, 2025 •

edited

Loading

Add infrastructure to simulate OpenHCL test failures

Introduced a OpenHCL command-line argument to define test scenarios.
Implemented custom actions based on the specified test scenario string.

This enables better debugging and validation of OpenHCL failure scenarios.

bhargavshah1988 added 7 commits

November 12, 2024 13:10


          Merge branch 'main' of https://github.com/bhargavshah1988/openvmm

57c366b


          Merge branch 'main' of https://github.com/bhargavshah1988/openvmm

2f4ad18


          Merge branch 'main' of https://github.com/bhargavshah1988/openvmm

a9e19ee


          Merge branch 'main' of https://github.com/bhargavshah1988/openvmm

9882a22


          Merge branch 'main' of https://github.com/bhargavshah1988/openvmm

05d1751


          Merge branch 'main' of https://github.com/bhargavshah1988/openvmm

29e5d92


          Add plumbing to pass test configuration

ae55107

bhargavshah1988 requested a review from a team as a code owner

January 30, 2025 00:45

This comment was marked as resolved.

Sign in to view

bhargavshah1988 changed the title ~~Add infrastructure to simulate the UH test failures~~ Add infrastructure to simulate the OpenHCL test failures

smalis-msft reviewed

View reviewed changes

openhcl/underhill_core/src/worker.rs Outdated Show resolved Hide resolved

daprilik reviewed

View reviewed changes

openhcl/underhill_core/src/options.rs Outdated Show resolved Hide resolved

daprilik reviewed

View reviewed changes

openhcl/underhill_core/src/dispatch/mod.rs Outdated Show resolved Hide resolved

smalis-msft reviewed

View reviewed changes

openhcl/underhill_core/src/dispatch/mod.rs Outdated Show resolved Hide resolved


          Use enum for test configuration

9b58780

smalis-msft reviewed

View reviewed changes

openhcl/underhill_core/src/dispatch/mod.rs Outdated Show resolved Hide resolved

smalis-msft reviewed

View reviewed changes

openhcl/underhill_core/src/options.rs Outdated Show resolved Hide resolved

smalis-msft reviewed

View reviewed changes

openhcl/underhill_core/src/options.rs Outdated Show resolved Hide resolved


          Update the alignment

6b9acb1

smalis-msft reviewed

View reviewed changes

openhcl/underhill_core/src/options.rs Outdated Show resolved Hide resolved


          Chagne the name of test cases

96ba588

daprilik reviewed

View reviewed changes

openhcl/underhill_core/src/worker.rs Outdated Show resolved Hide resolved

daprilik reviewed

View reviewed changes

openhcl/underhill_core/src/dispatch/mod.rs Outdated Show resolved Hide resolved


          Use future to wait

daprilik reviewed

View reviewed changes

openhcl/underhill_core/src/dispatch/mod.rs Outdated Show resolved Hide resolved

daprilik reviewed

View reviewed changes

openhcl/underhill_core/src/worker.rs Outdated Show resolved Hide resolved

daprilik reviewed

View reviewed changes

Contributor

daprilik left a comment

two small nits, but otherwise lgtm

bhargavshah1988 added 2 commits

January 30, 2025 16:38


          Alignment fix

75ed64e


          Alignment fix

050fbd2

daprilik approved these changes

View reviewed changes

bhargavshah1988 added the backport_2411 label

bhargavshah1988 merged commit 0cb7681 into microsoft:main

25 checks passed

bhargavshah1988 mentioned this pull request

Add infrastructure to simulate the OpenHCL test failures #753

Merged

bhargavshah1988 added a commit that referenced this pull request


          Add infrastructure to simulate the OpenHCL test failures (#753)

dac38a3

Add infrastructure to simulate OpenHCL test failures

- Introduced a OpenHCL command-line argument to define test scenarios.
- Implemented custom actions based on the specified test scenario
string.

This enables better debugging and validation of OpenHCL failure
scenarios.


CP: #742

Member

jstarks commented Feb 6, 2025

Backported in #753

jstarks added backported_2411 and removed backport_2411 labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported_2411