Some files are changed when building rest-server or webportal.

[ydye]

Every time I build webportal or rest-server, the script does some change on the following files. And I have to do some git operation, or I can't checkout to another branch directly. Bad development experience.

git checkout xxxxxxx
error: Your local changes to the following files would be overwritten by checkout:
        src/rest-server/package.json
        src/webportal/package.json
Please, commit your changes or stash them before you can switch branches.
Aborting

[abuccts]

What did you run?

[ydye]

What did you run?

clean branch, master , then build rest-server or webportal. You could have a try. Because a version is input into the package.json. So the code base is changed.

[abuccts]

You only need the following commands for dev purpose:

yarn
yarn dev

[ydye]

Anyway, I will create a PR to handle this issue. I don't think testing webportal or rest-server locally is a good experience. And every time you trigger the build process, you will have to clean the code base. It's not reasonable.

[ydye]

https://github.com/microsoft/pai/pull/3038/files

[abuccts]

You only need yarn dev or yarn build to build instead of running build-pre.sh, the script is only used in deployment.

[ydye]

@abuccts If you don't change the build logic, the problem still exits. Anyway, I have create the PR. And I prefer to test in docker container. So if you still think yarn dev or yarn build is better. Could you make some change on the building logic?

[abuccts]

I thought your problem is version in package.json will change in git repo.

The problem won't exist if you move npm version line into Dockerfile, it will change package.json file in Docker images, instead of your git repo.