Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Removing private SSH key #126

Closed
wants to merge 1 commit into from
Closed

Removing private SSH key #126

wants to merge 1 commit into from

Conversation

oudeismetis
Copy link

I noticed you had commited a private ssh key to your repo.

"I know. It was intentional."
Sorry to bother you then. Feel free to ignore this PR.
You know you can also secure private data while keeping it under source control.

"I didn't notice. What is this file? Is it a problem?"
This can be a very bad thing

"I keep accidentally typing git add ., any way I can prevent that from being an issue?"
There are a couple of steps you should take immediately:

  1. Avoid commands like git add . and git add *. It's better to be more explicit when you can.
  2. Assume your key is compromised. Unassociate it from any accounts you are using it for and generate a new key.
  3. Store your keys in a location outside of your project.
  4. Use a .gitignore file to prevent accidental commits of certain files.

Github also has a page about how to remove sensitive data from a repo.

Hope this PR finds you well

@msftclas
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ oudeismetis sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@fanyangCS
Copy link
Contributor

thanks for the kind reminder. the checkin was intentional.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants