[Cluster Object Model] Modify [ paictl cluster ] command, based on com. #1712
Conversation
2 similar comments
|
Please explain this PR in more details. Can you break this PR into smaller ones, each for one specific reason? |
Breaking this pr into small pieces will block ci/cd. Obviously, the main change is about translate the old cluster-object-model into the new cluster-object-model. You can see, there are a lot of template file is changed, due to this feature. But the logic is very simple. |
| self.logger.info("Create kube-proxy daemon for kuberentes cluster.") | ||
|
|
||
| file_path = "deployment/k8sPaiLibrary/template/kube-proxy.yaml.template" | ||
| template_data = common.read_template(file_path) | ||
| dict_map = { | ||
| "clusterconfig": self.cluster_config['clusterinfo'] | ||
| "com": com |
There was a problem hiding this comment.
Can we use more obvious name instead of abbreviation, maybe cluster_conf? Since all other service templates need this.
There was a problem hiding this comment.
template or python src
There was a problem hiding this comment.
template. The templates will need to write port: com["xxx"]["port"] right?
There was a problem hiding this comment.
Right. And Will port: cluster_conf["xxx"]['port'] be better?
There was a problem hiding this comment.
Yes, I think much better than com, since outside reader will have no clue of what it means.
There was a problem hiding this comment.
Rename it as cluster_cfg
* [Cluster Object Model] main module development (#1683) * [Cluster Object Model] Modify [ paictl cluster ] command, based on com. (#1712) * Class name modify. Pep8 (#1720) * [cluster object model] Change paictl machine‘s code, based on com. (#1723) * Add a tutorial to guide how to add new service configuraiton into com (#1701) * [Cluster Object Model] Modify [paictl service] command, based on new cluster-object-model (#1735)
Remove old mock cluster-object-model code from paictl cluster command. And integrate it with the new cluster-object-model