Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Trap SIGTERM in entrypoint to avoid yarn container early stop #2947

Merged
merged 1 commit into from
Jun 14, 2019
Merged

Trap SIGTERM in entrypoint to avoid yarn container early stop #2947

merged 1 commit into from
Jun 14, 2019

Conversation

mzmssg
Copy link
Member

@mzmssg mzmssg commented Jun 14, 2019

fix #2910

@coveralls
Copy link

Coverage Status

Coverage remained the same at 53.217% when pulling 6e9f5e6 on zimiao/entrypoint_trap into 347ef77 on master.

@mzmssg mzmssg requested a review from abuccts June 14, 2019 12:52
@mzmssg mzmssg merged commit 704afd7 into master Jun 14, 2019
@mzmssg mzmssg deleted the zimiao/entrypoint_trap branch June 14, 2019 13:52
@fanyangCS
Copy link
Contributor

is it a fix or just a mitigation?

@mzmssg
Copy link
Member Author

mzmssg commented Jun 24, 2019

@fanyangCS
A fix

@debuggy debuggy mentioned this pull request Jun 28, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@abuccts abuccts abuccts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Job failure due to two jobs on same GPU
4 participants
@mzmssg @coveralls @fanyangCS @abuccts