This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
[Kube Runtime] Add port conflict check #3259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add port conflict check in runtime.
Use regex to split.
mzmssg
reviewed
Jul 26, 2019
| portno: Port number to check. | ||
| """ | ||
| sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) | ||
| ret = sock.connect_ex(('localhost', portno)) |
There was a problem hiding this comment.
why not use sock.connect and catch exception
There was a problem hiding this comment.
because there's a connect_ex function which returns C connect system call's error code
mzmssg
approved these changes
Jul 26, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add port conflict check in runtime.