Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Add service deployment for hived scheduler #3495

Merged
merged 7 commits into from
Sep 5, 2019

Conversation

abuccts
Copy link
Member

@abuccts abuccts commented Aug 29, 2019

Add service deployment for hived scheduler.

Add service deployment for hived scheduler.
Add service config for hived scheduler.
@abuccts abuccts requested review from ydye and yqwang-ms August 29, 2019 13:05
pushd $(dirname "$0") > /dev/null

if kubectl get sts | grep -q "hivedscheduler-sts"; then
kubectl delete sts hivedscheduler-sts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete it like FC?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to make it a func?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could refine after https in apiserver enabled, make it a lib shared by all services

Update.
yqwang-ms
yqwang-ms previously approved these changes Aug 30, 2019
@abuccts abuccts mentioned this pull request Aug 30, 2019
42 tasks
./start.sh"]
env:
- name: KUBE_APISERVER_ADDRESS
value: "{{ cluster_cfg['layout']['kubernetes']['api-servers-url'] }}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should check whether it's a rbac cluster

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disable this env still cannot run in aks cluster, needs more changes after tested

image: gcr.io/google_containers/kube-scheduler:v1.14.2
command: [
"/usr/local/bin/kube-scheduler",
"--master={{ cluster_cfg['layout']['kubernetes']['api-servers-url'] }}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In rbac cluster, could it get the address from env?

Copy link
Member Author

@abuccts abuccts Sep 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just followed hived scheduler's README

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rbac issues can be fixed in other PR after fully tested

Remove hived scheduler config validation temporally,
because the paictl validation checks all services.
@abuccts abuccts closed this Sep 3, 2019
@abuccts abuccts reopened this Sep 3, 2019

template-list:
- hivedscheduler.yaml
- configmap.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configmap.yaml [](start = 4, length = 14)

configmap.yaml does not mean too much, rename it to hivedscheduler-config.yaml?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@yqwang-ms yqwang-ms dismissed their stale review September 3, 2019 13:01

revoking review

Rename configmap.yaml to hivedscheduler-config.yaml.
Copy link
Member

@yqwang-ms yqwang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@abuccts abuccts merged commit 6e3e3ff into master Sep 5, 2019
@abuccts abuccts deleted the xiongyf/hived-scheduler-service branch September 5, 2019 07:27
@hzy46 hzy46 mentioned this pull request Apr 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants