This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
[kubespray] Doc in contribute to guide user deploy k8s through kubespray #3757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please review each component's configuration |
abuccts
reviewed
Oct 21, 2019
Comment on lines
73
to
75
| - "--eviction-hard=" | ||
| - "--image-gc-high-threshold=100" | ||
| - "--image-gc-low-threshold=95" |
There was a problem hiding this comment.
these flags have been deprecated in kubelet.
This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
| ## Example: Up to 256 nodes, 100 pods per node (/16 network): | ||
| ## - kube_service_addresses: 10.233.0.0/17 | ||
| ## - kube_pods_subnet: 10.233.128.0/17 | ||
| ## - kube_network_node_prefix: 25 |
There was a problem hiding this comment.
the example makes it like a list
|
|
||
| ############## nginx configuration ############## | ||
|
|
||
| # Requests for load balancer app |
There was a problem hiding this comment.
pls keep the same format and use ##
Comment on lines
233
to
241
| --graph={{ docker_daemon_graph }} {% if ansible_os_family not in ["openSUSE Leap", "openSUSE Tumbleweed", "Suse"] %}{{ docker_log_opts }}{% endif %} | ||
| {%- else %} | ||
| --data-root={{ docker_daemon_graph }} {% if ansible_os_family not in ["openSUSE Leap", "openSUSE Tumbleweed", "Suse"] %}{{ docker_log_opts }}{% endif %} | ||
| {%- endif %} | ||
| {%- if ansible_architecture == "aarch64" and ansible_os_family == "RedHat" %} | ||
| --add-runtime docker-runc=/usr/libexec/docker/docker-runc-current | ||
| --default-runtime=docker-runc --exec-opt native.cgroupdriver=systemd | ||
| --userland-proxy-path=/usr/libexec/docker/docker-proxy-current --signature-verification=false | ||
| {%- endif -%} |
ydye
changed the title
yqwang-ms
approved these changes
Nov 12, 2019
ydye
changed the title
ydye
changed the title
ydye
changed the title
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3618