Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Add ".log" suffix for user-stdout/user-stderr/user-all log files #5272

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

Binyang2014
Copy link
Contributor

Add ".log" suffix for user-stdout/user-stderr/user-all log files
Fix: #5243

@Binyang2014 Binyang2014 requested a review from abuccts January 28, 2021 08:10
@Binyang2014 Binyang2014 mentioned this pull request Jan 28, 2021
55 tasks
@coveralls
Copy link

Coverage Status

Coverage remained the same at 33.91% when pulling 4aab288 on binyli/log-suffix into 30f21b3 on master.

@abuccts abuccts requested a review from Gerhut February 3, 2021 04:48
@Gerhut
Copy link
Member

Gerhut commented Feb 4, 2021

Why not directly add .log to the actual url? Avoid breaking change?

@Binyang2014
Copy link
Contributor Author

Why not directly add .log to the actual url? Avoid breaking change?

Because it's easier to implement and do not need to care about how log is stored.
The log url we returned is: https://pai-master/log-manager/..../api/v1/logs/user-stdout?...
The real log is stored at /var/pai/log/.../user-stdout/current
And we have some url such as https://pai-master/log-manager/..../api/v1/logs/user-stdout.1?... for rotated log.
The real log is stored at /var/pai/log/.../user-stdout/@....s

If we change url, we need to extract the real log folder before try to get the content. Using this way to avoid string manipulate

@Binyang2014 Binyang2014 merged commit 03c68a5 into master Feb 5, 2021
@Binyang2014 Binyang2014 deleted the binyli/log-suffix branch February 5, 2021 02:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can "View Full Log" display the log in a new tab?
3 participants