Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Fix get-pip.py compatibility problem with Python3.5 #5356

Merged
merged 7 commits into from
Mar 9, 2021

Conversation

hzy46
Copy link
Contributor

@hzy46 hzy46 commented Mar 8, 2021

https://bootstrap.pypa.io/get-pip.py is updated and doesn't support python3.5 anymore.

@hzy46 hzy46 requested a review from suiguoxin March 8, 2021 04:10
@coveralls
Copy link

coveralls commented Mar 8, 2021

Coverage Status

Coverage remained the same at 34.07% when pulling d23ecea on zhiyuhe/fix_pip_issue into f0dad8b on master.

@hzy46 hzy46 mentioned this pull request Mar 8, 2021
29 tasks
# "apt-get install python3" will install python3.5 on Ubuntu 16.04
# The lastest pip doesn't support python3.5.
# Here we use a fixed version number to ensure compatibility.
sudo python3 -m pip install pip==20.3.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please block pip3 version also in dev-box.common.dockerfile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only use fixed pip3 version.

pip for python2.7 has another issue.

@hzy46 hzy46 merged commit cf48368 into master Mar 9, 2021
@hzy46 hzy46 deleted the zhiyuhe/fix_pip_issue branch March 9, 2021 08:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants