Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Google Chrome leaves CrashPadMetrics files behind #27712

Closed
mxschmitt opened this issue Oct 19, 2023 · 1 comment
Closed

[BUG] Google Chrome leaves CrashPadMetrics files behind #27712

mxschmitt opened this issue Oct 19, 2023 · 1 comment
Assignees
@dgozman @mxschmitt
Labels
browser-chromium upstream This is a bug in something playwright depends on, like a browser. v1.40

Comments

@mxschmitt
Copy link
Member

image
@mxschmitt mxschmitt added browser-chromium upstream This is a bug in something playwright depends on, like a browser. v1.40 labels Oct 19, 2023
@mxschmitt
Copy link
Member Author

  • Its not reproducible all the time
  • Its not reproducible with Puppeteer, most likely because we use rimraf and they use fs.promises.rm to remove the userDatadir
  • If we change our logic to the following it works without leaving any directories behind or showing any error in the DEBUG logs:

image

Why does rimraf not delete the file? Because it does not retry EPERM errors while fs.promises.rm does. Confirmed while debugging as per here:

https://github.com/isaacs/rimraf/blob/81c631e8e27303ad7aa1f8de319463825b6ac7fc/src/retry-busy.ts#L26

@mxschmitt mxschmitt mentioned this issue Oct 25, 2023
Merged
mxschmitt added a commit that referenced this issue Oct 26, 2023
@mxschmitt
chore: get rid of rimraf package (#27790)
5f36608 
This seems more reliable nowadays as rimraf.

#27712

---------

Signed-off-by: Max Schmitt <[email protected]>
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this issue Oct 27, 2023
@mxschmitt @Germandrummer92
chore: get rid of rimraf package (microsoft#27790)
96367f4 
This seems more reliable nowadays as rimraf.

microsoft#27712

---------

Signed-off-by: Max Schmitt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgozman dgozman

@mxschmitt mxschmitt

Labels
browser-chromium upstream This is a bug in something playwright depends on, like a browser. v1.40
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dgozman @mxschmitt