feat: re-make global browser installation #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the `PLAYWRIGHT_GLOBAL_INSTALL=1` variable and instead introduces a new var - `PLAYWRIGHT_BROWSER_PATHS`. You can specify `PLAYWRIGHT_BROWSER_PATHS` to affect where playwright installs browsers and where it looks for browsers.
dgozman
approved these changes
Mar 24, 2020
| const webkitOptions = localDownloadOptions('webkit'); | ||
| if (!(await existsAsync(chromiumOptions.downloadPath))) { | ||
| await downloadBrowserWithProgressBar(chromiumOptions); | ||
| await protocolGenerator.generateChromiumProtocol(chromiumOptions.executablePath).catch(console.warn); |
There was a problem hiding this comment.
- we always install all three browsers on our CI and generate protocols for them
- the
firefox-linuxgithub action doesn't install chromium dependencies. I'd like to keep it this way so that our github action is lean and can be easily reused - the
generateChromiumProtocolfails if there are no chromium dependencies installed
PS: these checks were before in a form of try-catch.
| playwright.firefox._executablePath = downloadedBrowsers.ffExecutablePath; | ||
| playwright.webkit._executablePath = downloadedBrowsers.wkExecutablePath; | ||
| } catch (e) { | ||
| if (fs.existsSync(path.join(__dirname, '.local-browsers'))) { |
There was a problem hiding this comment.
Why this? Do we still expect playwright-core to work without external setup?
There was a problem hiding this comment.
this index.js is also used when playwright is installed from github (e.g. in case of our local development)
|
Works great, thank you! Just a minor issue I filed: #1651 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the
PLAYWRIGHT_GLOBAL_INSTALL=1variableand instead introduces a new var -
PLAYWRIGHT_BROWSERS_PATH.You can specify
PLAYWRIGHT_BROWSERS_PATHto affect where playwrightinstalls browsers and where it looks for browsers.
Fixes #1102