fix(webserver): do not spawn webserver as a new process group #18564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's revert separately and then carefully look at the actual bug and the right fix. |
yury-s
approved these changes
Nov 4, 2022
aslushnikov
added a commit
that referenced
this pull request
Nov 9, 2022
aslushnikov
force-pushed
the
properly-spawn-web-server-process
branch
from
d694499 to
455d4dc
Compare
This patch: - reverts c63a0b5. - stops using `processLauncher` to launch web servers. Process Launcher will spawn a new process group which is separate from test runner. This might result in unexpected behavior, e.g. `kill -sigkill -<testrunnerpid>` will orphane web server process. Instead, this patch simply spawns web server and sends `SIGTERM` to it when ready.
aslushnikov
force-pushed
the
properly-spawn-web-server-process
branch
from
455d4dc to
9fd07d8
Compare
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Nov 21, 2022
…microsoft#18564)" This reverts commit 26044c1. Fixes microsoft#18865
aslushnikov
added a commit
that referenced
this pull request
Nov 21, 2022
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Nov 21, 2022
…microsoft#18564)" (microsoft#18968) This reverts commit 26044c1. Fixes microsoft#18865
aslushnikov
added a commit
to aslushnikov/playwright
that referenced
this pull request
Nov 21, 2022
…bserver as a new process group" This reverts commit 26044c1 (PR microsoft#18564) Fixes microsoft#18865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch stops using
processLauncherto launch web servers. Process Launcherwill spawn a new process group which is separate from test runner.
This might result in unexpected behavior, e.g.
kill -sigkill -<testrunnerpid>will orphan web server process.Instead, this patch simply spawns web server and sends
SIGTERMto itwhen ready.