Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): docs links #19510

Merged
merged 2 commits into from
Dec 20, 2022
Merged

fix(docs): docs links #19510

merged 2 commits into from
Dec 20, 2022

Conversation

jfgreffier
Copy link
Contributor

fix some links in documentation

@pavelfeldman
Copy link
Member

The tests are likely to fail because we generate in-source documentation from these md files. You should check out the repo, apply these changes and build or run node ./utils/generate_types/.

docs/src/webview2.md Outdated Show resolved Hide resolved
Signed-off-by: Max Schmitt <[email protected]>
@mxschmitt
Copy link
Member

The tests are likely to fail because we generate in-source documentation from these md files. You should check out the repo, apply these changes and build or run node ./utils/generate_types/.

It should, but there is a bug currently that the links which get created do not consider "hash only links". I filed #19591 for it.

@mxschmitt mxschmitt merged commit 6846765 into microsoft:main Dec 20, 2022
@jfgreffier jfgreffier deleted the fix/dead-links branch December 20, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants