chore: drop dependency on playwright-core in all our packages #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yury-s
approved these changes
May 20, 2020
packages/build_package.sh
Outdated
| CLEANUP_PATHS+=("${README_PATH}") | ||
| cp ../README.md "${README_PATH}" | ||
| elif [[ "${PACKAGE_NAME}" == "playwright-core" ]]; then | ||
| PACKAGE_DESCRIPTION="A high-level API to automate web browsers" |
There was a problem hiding this comment.
Should we put a note that this package should not be used directly?
aslushnikov
commented
May 20, 2020
packages/build_package.sh
Outdated
| # 4. Build root package unless --no-build was provided. | ||
|
|
||
| if [[ -z "${NO_BUILD}" ]]; then | ||
| npm run build |
There was a problem hiding this comment.
- types are missing
- .npmignore is missing
- do not
npm run cleanand do notnpm run build - inherit most fields in
package.json
Also, rewrite in js to get a feeling
aslushnikov
force-pushed
the
remake-package-publishing
branch
from
f1baa0c to
f087031
Compare
dgozman
approved these changes
May 21, 2020
.npmignore
Outdated
| @@ -12,6 +12,10 @@ lib/injected/ | |||
|
|
|||
| # root for "playwright-core" package | |||
There was a problem hiding this comment.
While we are here, let's update this comment.
| @@ -12,6 +12,10 @@ lib/injected/ | |||
|
|
|||
| # root for "playwright-core" package | |||
| !index.js | |||
| !install.js | |||
| !README.md | |||
There was a problem hiding this comment.
You should read the first line of this file and enjoy :)
There was a problem hiding this comment.
: D whitelisting doesn't hurt, I guess :)
packages/build_package.js
Outdated
| // 3. figure package description and browsers based on name | ||
| let description = ''; | ||
| let whitelistedBrowsers = []; | ||
| if (packageName === 'playwright') { |
There was a problem hiding this comment.
I'd use an object with 'playwright-foo' keys.
packages/build_package.js
Outdated
| const toPath = path.join(packagePath, fileName); | ||
| cleanupPaths.push(toPath); | ||
| console.error(`- generating: //${path.relative(ROOT_PATH, toPath)}`); | ||
| await new Promise((resolve, reject) => { |
packages/build_package.js
Outdated
| const toPath = path.join(packagePath, fileOrDirectoryName); | ||
| cleanupPaths.push(toPath); | ||
| console.error(`- copying: //${path.relative(ROOT_PATH, fromPath)} -> //${path.relative(ROOT_PATH, toPath)}`); | ||
| await new Promise((resolve, reject) => { |
| npm publish packages/playwright-webkit --tag="${NPM_PUBLISH_TAG}" | ||
| npm publish packages/playwright-chromium --tag="${NPM_PUBLISH_TAG}" | ||
| npm publish packages/playwright --tag="${NPM_PUBLISH_TAG}" | ||
| PLAYWRIGHT_TGZ="$(node ./packages/build_package.js playwright ./playwright.tgz)" |
There was a problem hiding this comment.
Do we need to update the recipe on the bot to build beforehand?
This patch: - drops dependency on playwright-core in all our packages. Instead of the dependency, packages are now built with `//packages/build_package.sh` script. - unifies `browsers.json` - now there's a single `//browsers.json` file that is used to manage browser revisions. This patch temporary switches canary publishing to `--dryn-run` from CI/CD so that we can verify that it does sane things. We'll unify all our package management scripts under `//packages/` in a follow-up. Fixes microsoft#2268
aslushnikov
force-pushed
the
remake-package-publishing
branch
from
b7f4118 to
a18cb07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch:
the dependency, packages are now built with
//packages/build_package.shscript.
browsers.json- now there's a single//browsers.jsonfilethat is used to manage browser revisions.
This patch temporary switches canary publishing to
--dryn-runfrom CI/CD so that wecan verify that it does sane things.
We'll unify all our package management scripts under
//packages/in afollow-up.
Fixes #2268