chore(ct): resolve internal type errors

[sand4rt]

No description provided.

[pavelfeldman]

Same here, sounds like types are still problematic. How do we stabilize it?

[sand4rt]

A lot has happened in terms of types because it was messy from the start. I tried to improve things incrementally, which resulted in quite a few PRs in terms of types. In this case the type JsxComponent was just wrong which caused a ripple effect.

I think there are still some mistakes in the internal types. I can leave them alone as this is probably getting annoying

[pavelfeldman]

I think there are still some mistakes in the internal types. I can leave them alone as this is probably getting annoying

My general observation was that we tightened them first and then started relaxing them back and this relaxing process started to get involved. So I was wondering if we should relax them back to any to stop testing users' patience. But at the same time, if we think we are almost there or there, we can keep going all in.

[sand4rt]

My general observation was that we tightened them first and then started relaxing them back and this relaxing process started to get involved. So I was wondering if we should relax them back to any to stop testing users' patience. But at the same time, if we think we are almost there or there, we can keep going all in.

I see what you mean. I closed the other PR for the time being.

There are still some minor mistakes in the internal types and it might be good to relax the type hooksConfig since Svelte context and Map/Set support. It would also be nice to have the slots/events typed into the mount function as well some time. Other than we should be good.

This PR should not have consequences for the end user. It's all about the internal types.

[github-actions]

Test results for "tests 1"

9 flaky

⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › library/tracing.spec.ts:408:14 › should produce screencast frames crop
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [firefox] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [firefox] › page/page-request-continue.spec.ts:271:3 › should work with Cross-Origin-Opener-Policy
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › components/splitView.spec.tsx:65:5 › drag resize
⚠️ [webkit] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:167:5 › should update tracing network live

25875 passed, 603 skipped
✔️✔️✔️

Merge workflow run.

[pavelfeldman]

This type is very much public, so there are potential breakages still.