Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: switch gracefulShutdown to primarily mention SIGTERM and add Docker comment #34430

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

agg23
Copy link
Contributor

@agg23 agg23 commented Jan 22, 2025

Expand context on webserver.gracefulShutdown added by #34130. Mention SIGTERM as preferred signal and add note about Docker.

@agg23 agg23 merged commit 256dc47 into microsoft:main Jan 22, 2025
28 of 29 checks passed
agg23 added a commit to agg23/playwright that referenced this pull request Jan 22, 2025
agg23 added a commit that referenced this pull request Jan 22, 2025
Copy link
Contributor

Test results for "tests 1"

1 fatal errors, not part of any test

8 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:92:3 › should remove cookies by domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:93:11 › should proxy local network requests › by default › link-local @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:93:11 › should proxy local network requests › with other bypasses › loopback address @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/selector-generator.spec.ts:352:5 › selector generator › should match in shadow dom @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/video.spec.ts:379:5 › screencast › should capture navigation @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:147:3 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

37615 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants