chore: improve fix test prompt #34709
Open
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results for "tests 1"2 failed 7 flaky37836 passed, 654 skipped Merge workflow run. |
yury-s
approved these changes
Feb 10, 2025
| @@ -21,25 +21,33 @@ function stripAnsiEscapes(str: string): string { | |||
|
|
|||
| export function fixTestPrompt(error: string, diff?: string, pageSnapshot?: string) { | |||
| const promptParts = [ | |||
| 'This test failed, suggest how to fix it. Please be correct, concise and keep Playwright best practices in mind.', | |||
| `My Playwright test failed. What's going wrong?`, | |||
| `Please give me a suggestion how to fix it, and then explain what went wrong. Be very concise and apply Playwright best practices.`, | |||
There was a problem hiding this comment.
I'm not sure about the explain part, personally I'd like to see a fix which I could apply ASAP and only have an explanation on demand.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After playing around, this is a prompt I had good results with.