fix(testrunner): pass error into test fixtures #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
errorInFixture
branch
from
16fecbb to
dd0a98e
Compare
| }); | ||
|
|
||
| async function runTest(filePath: string) { | ||
| const outputDir = path.join(__dirname, 'test-results') |
There was a problem hiding this comment.
this will break if tests are run in parallel, which they are in my patch in review. #3595
There was a problem hiding this comment.
Would it make sense to convert runTest into a fixture that depends on the parallelIndex then to isolate output folders?
dgozman
reviewed
Aug 24, 2020
| @@ -81,7 +81,7 @@ export async function runTests(config: RunnerConfig, suite: Suite, reporter: Rep | |||
| // Trial run does not need many workers, use one. | |||
| const jobs = (config.trialRun || config.debug) ? 1 : config.jobs; | |||
| const runner = new Runner(suite, { ...config, jobs }, reporter); | |||
|
|
|||
| fs.mkdirSync(config.outputDir, { recursive: true }); | |||
There was a problem hiding this comment.
Let's also clean it before running?
There was a problem hiding this comment.
It can't because the index file is required by every test worker. This should be in cli right?
There was a problem hiding this comment.
I decided to clean it on the call site, otherwise can be unexpected...
dgozman
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.