Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pf pipeline tutorial #3488

Merged
merged 7 commits into from
Jul 3, 2024
Merged

Update pf pipeline tutorial #3488

merged 7 commits into from
Jul 3, 2024

Conversation

alainli0928
Copy link
Contributor

Description

Update pf component tutorial to highlight the output ports are required to be set as 'mount' when using multiple node.
Please add an informative description that covers that changes made by the pull request and link all relevant issues.

All Promptflow Contribution checklist:

  • [ y ] The pull request does not introduce [breaking changes].
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • [ y ] I have read the contribution guidelines.
  • Create an issue and link to the pull request to get dedicated review from promptflow team. Learn more: suggested workflow.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@alainli0928 alainli0928 requested a review from a team as a code owner July 2, 2024 08:49
@alainli0928 alainli0928 self-assigned this Jul 2, 2024
@github-actions github-actions bot added the examples Improvements on examples label Jul 2, 2024
wangchao1230
wangchao1230 previously approved these changes Jul 2, 2024
View reviewed changes
@alainli0928 alainli0928 requested a review from wangchao1230 July 3, 2024 03:24
wangchao1230
wangchao1230 previously approved these changes Jul 3, 2024
View reviewed changes
shift202
shift202 previously approved these changes Jul 3, 2024
View reviewed changes
@alainli0928 alainli0928 dismissed stale reviews from wangchao1230 and shift202 via 490ad3f July 3, 2024 06:41
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 3, 2024
@alainli0928 alainli0928 merged commit ac574fa into main Jul 3, 2024
13 checks passed
@alainli0928 alainli0928 deleted the pf-pipeline-tutorial-update-07022024 branch July 3, 2024 09:14
shift202
shift202 reviewed Jul 3, 2024
View reviewed changes
Copy link

@shift202 shift202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shift202 shift202 shift202 left review comments

@crazygao crazygao crazygao approved these changes

@wangchao1230 wangchao1230 wangchao1230 approved these changes

Assignees

@shift202 shift202

@wangchao1230 wangchao1230

@alainli0928 alainli0928

Labels
documentation Improvements or additions to documentation examples Improvements on examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alainli0928 @crazygao @shift202 @wangchao1230