Add the version into all links in the docs if it exists. #4334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelikhan
approved these changes
May 18, 2018
mmoskal
approved these changes
May 18, 2018
pelikhan
reviewed
May 18, 2018
pxtlib/docsrender.ts
Outdated
| const relative = href.indexOf('/') == 0; | ||
| const target = !relative ? '_blank' : ''; | ||
| if (relative && d.versionPath) href = `/${d.versionPath}${href}`; | ||
| return `<a href="${href}" ${title ? `aria-label="${title}"` : ''} ${target ? `target="${target}"` : ''}>${text}</a>`; |
There was a problem hiding this comment.
are these strings escaped already?
There was a problem hiding this comment.
This comment looks good: markedjs/marked#655 (comment)
There was a problem hiding this comment.
Good find. I'll use that comment instead and patch in my fix.
pelikhan
requested changes
May 18, 2018
|
Fixed. |
pelikhan
approved these changes
May 18, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds vN to all links rendered by the markdown if it exists. We also add the vN prefix for all links in the docs sidemenu.
Reason for changes, if you start browsing on makecode.microbit.org/vN you want to stay browsing on that site, rather than switch to latest.