Cache interpreter info in memory #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Jul 15, 2024
| @@ -8,7 +8,6 @@ msvc_spectre_libs = { version = "0.1.1", features = ["error"] } | |||
|
|
|||
| [dependencies] | |||
| pet-fs = { path = "../pet-fs" } | |||
| pet-python-utils = { path = "../pet-python-utils" } | |||
There was a problem hiding this comment.
Had to remove this incorrect depenedency, core should not have any other dependencies related to python interpreters and the like.
Hence the large number of files touched.
DonJayamanne
force-pushed
the
cacheInterpreterInfo3
branch
from
a13d8c1 to
bf032d3
Compare
DonJayamanne
commented
Jul 15, 2024
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| use std::path::PathBuf; |
There was a problem hiding this comment.
Moved from pet-python-utils
DonJayamanne
commented
Jul 15, 2024
|
|
||
| // #[test] | ||
| // #[cfg(unix)] | ||
| // fn test_hash_generation_upper_case() { |
There was a problem hiding this comment.
Will be enabled/implemented in a separate PR.
This pr will only focus on in memory caching.
DonJayamanne
commented
Jul 15, 2024
| pub symlinks: Option<Vec<PathBuf>>, | ||
| } | ||
|
|
||
| impl PythonEnv { |
There was a problem hiding this comment.
Moved to pet-core
alexr00
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.