Fixes to in-memory caching and added tests for file caching #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Jul 17, 2024
| @@ -57,6 +60,14 @@ pub fn get_python_info( | |||
| Some(env) | |||
| } | |||
|
|
|||
| fn get_version(resolved_exe: &Path) -> Option<String> { | |||
| let python_version = resolved_exe.to_string_lossy().to_string(); | |||
| match PYTHON_VERSION.captures(&python_version) { | |||
There was a problem hiding this comment.
Found a bug, as a result of the CI containers getting updated..
DonJayamanne
changed the title
DonJayamanne
force-pushed
the
fixesToInMemoryCaching
branch
from
8ba02c1 to
54c8495
Compare
DonJayamanne
force-pushed
the
fixesToInMemoryCaching
branch
from
965bad6 to
7cd319b
Compare
DonJayamanne
force-pushed
the
fixesToInMemoryCaching
branch
from
c858866 to
e32393e
Compare
DonJayamanne
force-pushed
the
fixesToInMemoryCaching
branch
from
e32393e to
24c45d4
Compare
DonJayamanne
force-pushed
the
fixesToInMemoryCaching
branch
from
0cfb8cc to
3dedc79
Compare
aeschli
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.