normalize all paths
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
force-pushed
the
normalizePaths2
branch
from
03fbba2 to
999a8bc
Compare
DonJayamanne
commented
Jun 5, 2024
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| use crate::env_variables::EnvVariables; | |||
| use log::trace; | |||
| use pet_utils::path::fix_file_path_casing; | |||
There was a problem hiding this comment.
Rename to make the new intent clear
DonJayamanne
commented
Jun 5, 2024
| if let Ok(resolved) = fs::canonicalize(&path) { | ||
| // Return the path as is. | ||
| if cfg!(unix) { | ||
| return resolved; |
There was a problem hiding this comment.
Return the normalized paths even for linux (this is the main change)
DonJayamanne
commented
Jun 5, 2024
|
|
||
| #[cfg(unix)] | ||
| #[test] | ||
| fn read_environment_txt() { | ||
| use common::{create_env_variables, resolve_test_path}; | ||
| use pet_conda::environment_locations::get_conda_envs_from_environment_txt; | ||
| use std::path::PathBuf; |
There was a problem hiding this comment.
Also fixed some linter warnings
rzhao271
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.