-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid to set refs on stateless components #866
Conversation
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
@farwayer, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's better explicitly ask for withRef option like how redux connect does
Ask for what? |
Set the ref only if withRef option is provided and check if ref exists before using it in any function |
Guys - I believe we can merge this changes to Master and we can always enhance this in future if needed. Please feel free to voice your concerns or suggestions if any. |
fix #865 #750