Cherry-pick: Bump android Appcompat to 1.4.1 #1236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Currently we are using Appcompat in version 1.0.2 which is almost 4 years old now, this PR updates it to version 1.4.1. Using Appcompat 1.0.2 was also causing a crash on RNTester due to an error where FontFamily's method was not found (Related to facebook#33065) Closes facebook#31620 ## Changelog [Android] [Changed] - Bump android Appcompat to 1.4.1 Pull Request resolved: facebook#33072 Test Plan: Use `./scripts/test-manual-e2e.sh` to test both RNTester and a new app Reviewed By: cortinico Differential Revision: D34107105 Pulled By: ShikaSD fbshipit-source-id: 966e4687b09ae50a88ee518622f073d72e8c6550
mganandraj
approved these changes
Jul 7, 2022
rasaha91
added a commit
to rasaha91/react-native-macos
that referenced
this pull request
Jul 7, 2022
…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1
rasaha91
added a commit
to rasaha91/react-native-macos
that referenced
this pull request
Jul 7, 2022
…-upgrade Cherry-pick: Bump android Appcompat to 1.4.1
rasaha91
added a commit
that referenced
this pull request
Jul 7, 2022
Merge pull request #1236 from rasaha91/cherry-pick-appcompat-upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently we are using Appcompat in version 1.0.2 which is almost 4 years old now, this PR updates it to version 1.4.1.
Using Appcompat 1.0.2 was also causing a crash on RNTester due to an error where FontFamily's method was not found (Related to facebook#33065)
Closes facebook#31620
Changelog
[Android] [Changed] - Bump android Appcompat to 1.4.1
Pull Request resolved: facebook#33072
Test Plan: Use
./scripts/test-manual-e2e.shto test both RNTester and a new appReviewed By: cortinico
Differential Revision: D34107105
Pulled By: ShikaSD
fbshipit-source-id: 966e4687b09ae50a88ee518622f073d72e8c6550