Remove TextInput cursor color changes with selectionColor prop changes #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
reviewed
Apr 13, 2023
packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js
Outdated
Show resolved
Hide resolved
Saadnajmi
reviewed
Apr 13, 2023
packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js
Outdated
Show resolved
Hide resolved
lenaic
force-pushed
the
fix-textinput-cursor-color
branch
from
5223fc7 to
b144fb6
Compare
Saadnajmi
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
The caret color on macOS should stay visible at all times. This changes the behavior of the singleline and multiline TextInput to avoid changing the caret color.
Changelog
[macOS] [CHANGED] - TextInput selectionColor won't change cursorColor
Test Plan
In the following recordings, the caret color is set to the system default for a TextInput with a non-default selection color.
Light mode:
Screen.Recording.2023-04-13.at.18.59.04.mov
Dark mode:
Screen.Recording.2023-04-13.at.18.59.42.mov