Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fabric] Pipe through ImageLoadError and ImageErrorInfo data #13262

Closed
marlenecota opened this issue May 21, 2024 · 1 comment · Fixed by #13285
Closed

[Fabric] Pipe through ImageLoadError and ImageErrorInfo data #13262

marlenecota opened this issue May 21, 2024 · 1 comment · Fixed by #13285
Assignees
@acoates-ms
Labels
Area: Fabric Support Facebook Fabric Area: Image enhancement Integration Follow-up
Milestone
Backlog

Comments

@marlenecota
Copy link
Contributor

Summary

Integration #13261 brings in this change facebook/react-native@78ab5f4 which now passes ImageLoadError and ImageErrorInfo objects to Image events. Currently we're passing in blank values.

Motivation

Parity with upstream

Basic Example

No response

Open Questions

No response
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 21, 2024
@marlenecota marlenecota mentioned this issue May 21, 2024
Merged
marlenecota added a commit to marlenecota/react-native-windows that referenced this issue May 21, 2024
@marlenecota
add TODO: microsoft#13262 comment for ImageLoadError follow up
675e25a
marlenecota added a commit that referenced this issue May 22, 2024
@marlenecota
Integration 04/27/24 (e2ad6696d) (#13261)
3d221a9 
* RN Integration 04/27

* Change files

* fixes

* formatting

* add TODO: #13262 comment for ImageLoadError follow up

* align TextExample with android

* TextExample: no nested views in text

* revert textexample

* No TextInlineViewsExample

* snapshots
@microsoft-github-policy-service microsoft-github-policy-service bot added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label May 23, 2024
@chrisglein
Copy link
Member

Look for TODOs with this issue number where the data is being passed as blank.

@chrisglein chrisglein removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric labels May 23, 2024
@chrisglein chrisglein added this to the Backlog milestone May 23, 2024
@acoates-ms acoates-ms mentioned this issue May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acoates-ms acoates-ms

Labels
Area: Fabric Support Facebook Fabric Area: Image enhancement Integration Follow-up
Projects
RNW New Architecture
Status: Done
Milestone
Backlog
3 participants
@marlenecota @chrisglein @acoates-ms