Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabric secure text entry #11484

Merged
merged 5 commits into from
Apr 17, 2023
Merged

Fabric secure text entry #11484

merged 5 commits into from
Apr 17, 2023

Conversation

chrisglein
Copy link
Member

@chrisglein chrisglein commented Apr 11, 2023 •
edited
Loading

Description

Type of Change

  • New feature (non-breaking change which adds functionality)

Why

Resolves #11457

What

  • Supply password character
  • Set TXTBIT_USEPASSWORD
  • Fix problem when backspacing on short strings

Screenshots

image

Testing

Applied change to RNW in node_modules for a Fabric app.

Ran in playground composition
image

Microsoft Reviewers: Open in CodeFlow

@chrisglein
Enable secureTextEntry for Fabric
bcdecb1 
- Supply password character
- Set TXTBIT_USEPASSWORD
- Fix problem when backspacing on short strings
@chrisglein
Change files
776a7df
@chrisglein chrisglein added the Area: Fabric Support Facebook Fabric label Apr 11, 2023
@chrisglein chrisglein requested a review from a team as a code owner April 11, 2023 20:21
@chrisglein chrisglein added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Apr 17, 2023
@chrisglein chrisglein merged commit d1c012c into microsoft:main Apr 17, 2023
@chrisglein chrisglein deleted the fabricSecureTextEntry branch April 17, 2023 22:10
@jonthysell jonthysell mentioned this pull request Apr 20, 2023
Closed
233 tasks
@jonthysell jonthysell added the New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asklar asklar asklar left review comments

@acoates-ms acoates-ms acoates-ms approved these changes

@marlenecota marlenecota marlenecota approved these changes

@TatianaKapos TatianaKapos Awaiting requested review from TatianaKapos

Assignees
No one assigned
Labels
Area: Fabric Support Facebook Fabric Area: TextInput AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
RNW New Architecture
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement TextInput.secureTextEntry for Fabric
5 participants
@chrisglein @marlenecota @asklar @acoates-ms @jonthysell