-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fabric] Expand native theming implementation #12287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoates-ms
changed the title
Expand native theming implementation
[Fabric] Expand native theming implementation
Oct 25, 2023
Closed
chiaramooney
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing changes look good to me!
TatianaKapos
approved these changes
Oct 25, 2023
This was referenced Nov 7, 2023
jonthysell
added
the
New Architecture
Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
label
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Fabric
Support Facebook Fabric
New Architecture
Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Theme
object allowing future tree specific theming and native theme injection.Switch
,TextInput
andActivityIndicator
.rootComponentView
lookup.CompActivityVisual
,CompCaretVisual
, andCompSwitchThumbVisual
to take brushes instead of colors for expanded brush supportScrollItem
andValue
accessibility patternsIsOffScreen
accessibility propertyScrollView
that was scrolled to a non-zero offsetScrollView
would still be hit tested.Microsoft Reviewers: Open in CodeFlow