Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fabric] Add caretHidden to TextInput #12430

Merged
merged 10 commits into from
Dec 6, 2023

Conversation

TatianaKapos
Copy link
Contributor

@TatianaKapos TatianaKapos commented Nov 22, 2023

Description

Adds caretHidden to Fabric's TextInput

Type of Change

  • New feature (non-breaking change which adds functionality)

Why

Component Parity with Paper

What

Overrides RichEdit controlling the visibility of the caret visual if caretHidden is set to true.

Screenshots

Playground-composition_QgRetsx9f3.mp4

Testing

tested locally

Changelog

no

Microsoft Reviewers: Open in CodeFlow

@TatianaKapos TatianaKapos requested a review from a team as a code owner November 22, 2023 00:44
@TatianaKapos TatianaKapos changed the title Tk caret hidden [Fabric] Add caretHidden to TextInput Nov 22, 2023
@chiaramooney
Copy link
Contributor

@TatianaKapos When the PR is ready to submit let me know and we can chat about how to add tests for this to the E2E test app. Would be a cool milestone to have the feature and corresponding tests merged at the same time!

@chiaramooney
Copy link
Contributor

Could you also add a test to TextInputComponentTest.test.ts and call DumpVisualTree on the testID you added? Example here!

test('TextInputs can customize its padding', async () => {
const component = await app.findElementByTestID('textinput-padding');
await component.waitForDisplayed({timeout: 5000});
const dump = await dumpVisualTree('textinput-padding');
expect(dump).toMatchSnapshot();

Copy link
Contributor

@chiaramooney chiaramooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TatianaKapos TatianaKapos merged commit 3ac229a into microsoft:main Dec 6, 2023
43 checks passed
@TatianaKapos TatianaKapos deleted the tk-caretHidden branch December 6, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants