-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fabric] Add caretHidden to TextInput #12430
Conversation
vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/CompositionContextHelper.cpp
Outdated
Show resolved
Hide resolved
@TatianaKapos When the PR is ready to submit let me know and we can chat about how to add tests for this to the E2E test app. Would be a cool milestone to have the feature and corresponding tests merged at the same time! |
Could you also add a test to TextInputComponentTest.test.ts and call DumpVisualTree on the testID you added? Example here! react-native-windows/packages/e2e-test-app-fabric/test/TextInputComponentTest.test.ts Lines 638 to 642 in 1582219
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Description
Adds caretHidden to Fabric's TextInput
Type of Change
Why
Component Parity with Paper
What
Overrides RichEdit controlling the visibility of the caret visual if caretHidden is set to true.
Screenshots
Playground-composition_QgRetsx9f3.mp4
Testing
tested locally
Changelog
no
Microsoft Reviewers: Open in CodeFlow