-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Desktop NUSPEC to use ARM64EC #13335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vmoroz
approved these changes
Jun 11, 2024
dannyvv
approved these changes
Jun 11, 2024
jeffstall
suggested changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to have both ARM64 and ARM64EC builds. We can't replace one with the other. There's usage cases for both. Can you please update?
jeffstall
suggested changes
Jul 1, 2024
dannyvv
approved these changes
Jul 9, 2024
vmoroz
approved these changes
Jul 9, 2024
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jul 19, 2024
* Update Desktop NUSPEC to use ARM64EC * Change files * Enable ARM64EC ReactWindows CI artifact * Add ARM64EC|Release to nuget-desktop.yml * Revert ARM64EC for ReactWindows artifact * Exclude ARM64EC React.Windows.Desktop.Test.DLL from NUSPEC
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jul 19, 2024
* Update Desktop NUSPEC to use ARM64EC * Change files * Enable ARM64EC ReactWindows CI artifact * Add ARM64EC|Release to nuget-desktop.yml * Revert ARM64EC for ReactWindows artifact * Exclude ARM64EC React.Windows.Desktop.Test.DLL from NUSPEC
JunielKatarn
added a commit
that referenced
this pull request
Jul 19, 2024
* Update Desktop NUSPEC to use ARM64EC (#13335) * Increase Desktop job timeouts due to #13442 (#13444) --------- Co-authored-by: Marlene Cota <[email protected]>
JunielKatarn
added a commit
to jurocha-ms/react-native-windows
that referenced
this pull request
Jul 19, 2024
* Update Desktop NUSPEC to use ARM64EC * Change files * Enable ARM64EC ReactWindows CI artifact * Add ARM64EC|Release to nuget-desktop.yml * Revert ARM64EC for ReactWindows artifact * Exclude ARM64EC React.Windows.Desktop.Test.DLL from NUSPEC
JunielKatarn
added a commit
that referenced
this pull request
Jul 19, 2024
* Port Desktop DLL to ARM64EC (#13320) * Upgrade WinSDK version for C/C++ projects * Do not build Integration Test projects for ARM64EC * Make V8Platform x64 for ARM64EC * Override HermesPlatform for ARM64EC * Override WinAppSDK platforms for ARM64EC * Exclude OpenSSL on Desktop DLL for ARM64EC * Override WinAppSDK _MrtCoreRuntimeIdentifier * Add explicit LIB dependencies for ARM64EC * Skip React.Windows.IntegrationTests on ARM64EC * Remove OpenSSL from Desktop LIB and DLL * /t:Vars - Log SolutionName * Update Desktop NUSPEC to use ARM64EC (#13335) * Add ARM64EC strip slices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add ARM64EC platform to Desktop NuGet.
Type of Change
Why
Currently the Desktop NUSPEC
OfficeReact.Win32.nuspec
expects source and target paths for ARM64.What
Change the NUSPEC entries from
ARM64
toARM64EC
.Microsoft Reviewers: Open in CodeFlow