[Telemetry] Add RnwNewArch to MSBuildProperties
#14208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yajur-Grover
approved these changes
Dec 16, 2024
jonthysell
reviewed
Dec 16, 2024
| @@ -18,7 +18,8 @@ | |||
| "WindowsTargetPlatformVersion": "$(WindowsTargetPlatformVersion)", | |||
| "UseExperimentalNuGet": "$(UseExperimentalNuGet)", | |||
| "UseHermes": "$(UseHermes)", | |||
| "UseWinUI3": "$(UseWinUI3)" | |||
| "UseWinUI3": "$(UseWinUI3)", | |||
There was a problem hiding this comment.
Not that I particularly like it, but you could include UseFabric in here just in case to catch edge cases.
There was a problem hiding this comment.
What edge cases would be covered by including UseFabric that RnwNewArch would not?
jonthysell
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
RnwNewArchandUseFabricproperties to MSBuildProperties, indicating if the project is using Paper or Fabric.Type of Change
Why
By using telemetry data, we want to determine the adoption level of Fabric.
Resolves #14047
What
Included
RnwNewArchandUseFabricin the properties written into msproperties.g.json (via OutputMSBuildProperties.targets), which are picked up byrun-windowsto pass all the properties asextraPropsfor telemetry logging.Screenshots
Testing
Ran
run-windowsin a debugger and verified thatRnwNewArchandUseFabricare written into msproperties.g.json and they are passed toTelemetry.trackCommandEvent().Changelog
No
Microsoft Reviewers: Open in CodeFlow