[0.73] Fix calls to std::mutex::lock #14225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthysell
approved these changes
Dec 20, 2024
Replaced sizeof...(I) with std::index_sequence<I...>::size()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick #14223
Description
Fix failing calls to std::mutex::lock.
Type of Change
Why
There are some reports that a first call to std::mutex::lock fail.
The issue seems to be related to ABI incompatibility between the RNW DLL and the VCLib DLL.
What
To address this issue we define the
_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTORpreprocessor definition.See:
Changelog
Add
_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTORpreprocessor definition to fix failing calls to std::mutex::lock.Microsoft Reviewers: Open in CodeFlow