Add support for Flyout Horizontal and Vertical Offset #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* suppress new folly warning in msoFolly.h * add export for const dynamic operator[]str
* Fix first launch and reload/unload issue * Reword the error message * rename the helper to wrapper * PrepareJavaScriptRuntime from 750ms to 5s * use shared_from_this * remove ThisWrapper * ReactControl in rt to shared_ptr
A few deprecations and refactorings caused issues with the upgrade to 0.58. This was all the changes to JS necessary to get RNTester working.
* Refactored root folders * Updated path references * Fixed appveyor.yml
* Update CODEOWNERS * Remove old ISSUE_TEMPLATES
* Committing changes to master readme * Updating to address review feedback
* Define test WebSocket types. * Use CRLF for C++ files. * Try basic_stream_socket over IWebSocketStream. * Use boost::beast::test::stream. * Defined async_connect(test::stream& ... * Move custom async_connect into WebSocket.cpp. * Defined MockStreamLayer subtype. * Use errc::make_error_code. * Define MockStream, equivalent to websocket::stream * Implement async read and write in MockStreamLayer. * Override boost::beast::http::async_read and write. * Move TestWebSocket implementation to CPP file. * Stop including <boost/beast/experimental/test/stream.hpp>. * Simplify template decls for SecureWebSocket. * Simplified WebSocket template declaration. * Updated namespace for WebSocket-related APIs. * Reset default platform to x64 in SLN. * Re-located BaseWebSocketTest.
* End of line updates for inconsistent CPP files. * Fixed symbol typo.
* draft * workaround cppwinrt error * popup fix * rollback change to popup and update Flyout * update comment from popup to flyout * change signature and rename getShadowNodeWithXamlRoot * draft * workaround cppwinrt error * popup fix * rollback change to popup and update Flyout * update comment from popup to flyout * change signature and rename getShadowNodeWithXamlRoot * install SDK * install SDK for win32 * install desktopcpp
* Add accessibilityLiveRegion property to FrameworkElementViewManager * Added AccessibilityUtils.h with helper method to announce the LiveRegion change * Fixed bug and added example in RNTester
ghost
added
the
khetanashita
assigned ahimberg, acoates-ms and a00889920 and unassigned ahimberg, acoates-ms and a00889920
ahimberg
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow