Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support autoCapitalize Characters #3406

Merged
merged 5 commits into from
Oct 17, 2019
Merged

Support autoCapitalize Characters #3406

merged 5 commits into from
Oct 17, 2019

Conversation

ddalp
Copy link
Contributor

@ddalp ddalp commented Oct 14, 2019

#3085

  • For autoCaptialize, we can only support characters today. Rest(word, sentence) can be done after we support lifted XAML.
  • A e2e test is added to check the input capitalization.
Microsoft Reviewers: Open in CodeFlow

@ddalp ddalp requested a review from a team as a code owner October 14, 2019 18:28
@ghost ghost added the vnext label Oct 14, 2019
} else if (propertyName == "autoCapitalize") {
if (propertyValue.isString()) {
if (propertyValue.asString() == "characters") {
textBox.CharacterCasing(winrt::CharacterCasing::Upper);
Copy link
Contributor

@licanhua licanhua Oct 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CharacterCasing [](start = 22, length = 15)

Please pay attention, CharacterCasing is introduced since 16299 but vnext supports 15063 #Resolved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I forgot about that this was a recent supported property.


In reply to: 334735165 [](ancestors = 334735165)

Copy link
Contributor

@licanhua licanhua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ddalp ddalp merged commit f12f3f3 into microsoft:master Oct 17, 2019
@ddalp ddalp deleted the autoCapital branch October 17, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants