Fix Crash Using accessibilityValue Outside of Web Debugging #5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing code will crash with a folly TypeError since we enforce the folly::dynamic value is an integer. Using Chakra, in AccessibilityExample we see the dynamic for min represented as a double (0.00000) and crash. We're converting to a double anyway, so we instead rely on builtin folly type converstion instead of trying to coerce the value to an int to convert into a double again. Note that we still see issues with the AccessibilityExample page.
asklar
approved these changes
Aug 1, 2020
dannyvv
approved these changes
Aug 3, 2020
NickGerleman
added a commit
to NickGerleman/react-native-windows
that referenced
this pull request
Aug 3, 2020
…t#5619) * Fix Crash Using accessibilityValue Without Web Debugging Existing code will crash with a folly TypeError since we enforce the folly::dynamic value is an integer. Using Chakra, in AccessibilityExample we see the dynamic for min represented as a double (0.00000) and crash. We're converting to a double anyway, so we instead rely on builtin folly type converstion instead of trying to coerce the value to an int to convert into a double again. Note that we still see issues with the AccessibilityExample page. * Change files
ghost
pushed a commit
that referenced
this pull request
Aug 4, 2020
…5624) * Fix Crash Using accessibilityValue Without Web Debugging Existing code will crash with a folly TypeError since we enforce the folly::dynamic value is an integer. Using Chakra, in AccessibilityExample we see the dynamic for min represented as a double (0.00000) and crash. We're converting to a double anyway, so we instead rely on builtin folly type converstion instead of trying to coerce the value to an int to convert into a double again. Note that we still see issues with the AccessibilityExample page. * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Chakra, in AccessibilityExample we see the dynamic for min represented as a double (0.00000) and crash with a folly TypeError since we enforce the folly::dynamic value is an integer.
We're converting to a double anyway, so we instead rely on built-in folly type conversion instead of trying to coerce the value to an int to convert into a double again. (i.e. asDouble will convert an int to a double as well).
Note that we still see issues with the AccessibilityExample page that need to be addressed.
Will cherry-pick this into 0.63-stable.
Microsoft Reviewers: Open in CodeFlow