-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.64] Port windows fork of Pressable to win32 #9350
Merged
NickGerleman
merged 11 commits into
microsoft:0.64-stable
from
Saadnajmi:pressable-win32-64
Jan 10, 2022
Merged
[0.64] Port windows fork of Pressable to win32 #9350
NickGerleman
merged 11 commits into
microsoft:0.64-stable
from
Saadnajmi:pressable-win32-64
Jan 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Port windows Pressable override to win32 * Change files * Add override * lint fix * More overrides, more windows comments * Change files * fix overrides * Add win32 to HoverState * Overrride types maybe? * Add keyboarding types to View.win32.js * override ViewPropTypes.win32.js * fix flowconfig
…e-windows into pressable-win32-64
Not sure why CI is failing on this one.. |
@Saadnajmi it's unrelated to your change. An admin can bypass PR checks and merge. |
NickGerleman
approved these changes
Jan 10, 2022
Thanks, that would be appreciated 🙏 |
8 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #9132
Also adds facebook/react-native#32405 for hover support on Pressable for react-native-windows
Microsoft Reviewers: Open in CodeFlow