Skip to content

Commit

Permalink
Merge from master (#253)
Browse files Browse the repository at this point in the history
* 7.1.1

* 7.1.2 Fix #218 (#219)

* 7.1.2 Fix #218

* Fix typo

* Track content changed events and report up to PickerPluginDataProvider (#222)

* Refactor ReplaceWithNode to use the editor core API (#223)

* Address comments raised in #225 but not addressed (#227)

* Fix a js error in insertNode (#229)

* 7.2.0 (#230)

* Fix 4 issues (#234)

* Fix #74 (#236)

* Fix #74

* Fix #74

* address comments

* Replace deprecated TSLint extension with MSFT TSLint (#240)

* 7.2.1 (#243)

* stopPropagation for key inputs (#245)

* Make picker plugin generic (#246)

* Make PickerPlugin generic

* fix build

* Selection Management step 1 (#247)

* Selection management step 1: New core API selectRange

* Fix build

* fix comment

* Fix keyboard event issue (#251)
  • Loading branch information
JiuqingSong authored Mar 5, 2019
1 parent d676b03 commit 5b915a6
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "roosterjs",
"version": "7.2.2-darkmode.0",
"version": "7.2.3-darkmode.0",
"description": "Framework-independent javascript editor",
"repository": {
"type": "git",
Expand Down
9 changes: 8 additions & 1 deletion packages/roosterjs-editor-core/lib/coreAPI/attachDomEvent.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,14 @@ const attachDomEvent: AttachDomEvent = (
// This detection is not 100% accurate. event.key is not fully supported by all brwosers, and in some browser (e.g. IE)
// event.key is longer than 1 for num pad input. But here we just want to improve performance as mush as possible.
// So if we missed some case here it is still acceptable.
if (isKeyboardEvent(event) && event.key && event.key.length == 1) {
if (
isKeyboardEvent(event) &&
!event.ctrlKey &&
!event.altKey &&
!event.metaKey &&
event.key &&
event.key.length == 1
) {
event.stopPropagation();
}

Expand Down

0 comments on commit 5b915a6

Please sign in to comment.