Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[A11y] Value returned for announceListItemNumbering in announcerStringGetter is not used when numbered list is created with toggleNumbering api #2734

Closed
vhuseinova-msft opened this issue Jun 28, 2024 · 1 comment · Fixed by #2743
Closed

[A11y] Value returned for announceListItemNumbering in announcerStringGetter is not used when numbered list is created with toggleNumbering api #2734

vhuseinova-msft opened this issue Jun 28, 2024 · 1 comment · Fixed by #2743

Comments

@vhuseinova-msft
Copy link
Contributor

Describe the bug
RoosterJS provides a way to set a custom announcements for new items in numbered list (announcerStringGetter). But it looks like value returned for announceListItemNumbering in announcerStringGetter is not used when numbered list is created with toggleNumbering api.
Please note that numbered lists that are created with auto formatting, use announceListItemNumbering as expected.

To Reproduce
Steps to reproduce the behavior:

  1. Open Rooster JS demo web site
  2. Click add numbered list button
  3. type some text
  4. Press enter
  5. Observe that Narrator/VoiceOver doesn't announce a custom announcement for announceListItemNumbering

Expected behavior
The announceListItemNumbering string returned in announcerStringGetter should be used to announce when a new bullet is added (in autoformatted list and when list is added with toggleNumbering api)

Device Information

  • OS: [e.g. iOS] MacOS
  • Browser [e.g. chrome, safari] Edge
  • Version [e.g. 22]
@vhuseinova-msft
Copy link
Contributor Author

cc @BryanValverdeU

@BryanValverdeU BryanValverdeU mentioned this issue Jul 11, 2024
Merged
BryanValverdeU added a commit that referenced this issue Jul 11, 2024
@BryanValverdeU
Fix #2734 by Setting List Metadata applyListStyleFromLevel: true wh…
5e2b680 
…en toggling a list (#2743)

* init

* Tests

* add missing file
ianeli1 added a commit that referenced this issue Jul 15, 2024
@ianeli1 @vhuseinova-msft
@BryanValverdeU @juliaroldi
Bump Rooster main to 9.8.0 (#2746)
db0ac97 
* Export DefaultSanitizers to be available in roosterjs-content-model-plugins package #2739

* Fix #2741 by changing Id selectors from `#{id}` to `[id="{id}"]` (#2742)

* init

* Fix build

* fix selection

* fix

* fixes

* remove console.log

* fix test

* Fix #2734 by Setting List Metadata `applyListStyleFromLevel: true` when toggling a list (#2743)

* init

* Tests

* add missing file

* crop alternative

* Fix #2733 by changing the approach to announce repeated announce messages (#2745)

* init

* move string to constant

* bump version

---------

Co-authored-by: vhuseinova-msft <[email protected]>
Co-authored-by: Bryan Valverde U <[email protected]>
Co-authored-by: Julia Roldi (from Dev Box) <[email protected]>
Co-authored-by: Julia Roldi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@vhuseinova-msft