Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add font-size in image wrapper. #1946

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Add font-size in image wrapper. #1946

merged 4 commits into from
Jul 13, 2023

Conversation

juliaroldi
Copy link
Contributor

Add font-size in image wrapper, so it do not inherit font-size.

To test:

  1. Apply a big font-size to a image
  2. The image rotate handler icon will move out the rotate button
    fontOnImageBug

After fix:
fontOnImage

@juliaroldi juliaroldi requested review from ianeli1, JiuqingSong, flyingbee2012, BryanValverdeU and Andres-CT98 and removed request for ianeli1 July 12, 2023 22:10
@juliaroldi juliaroldi merged commit f77648f into master Jul 13, 2023
@JiuqingSong JiuqingSong deleted the u/juliaroldi/font-image-handler branch August 4, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JiuqingSong JiuqingSong JiuqingSong approved these changes

@flyingbee2012 flyingbee2012 Awaiting requested review from flyingbee2012

@BryanValverdeU BryanValverdeU Awaiting requested review from BryanValverdeU

@ianeli1 ianeli1 Awaiting requested review from ianeli1

@Andres-CT98 Andres-CT98 Awaiting requested review from Andres-CT98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliaroldi @JiuqingSong