Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 216431 #1958

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Fix 216431 #1958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
982de50
Fix 216431
JiuqingSong Jul 17, 2023
2b4c094
Merge branch 'master' into u/jisong/216431
JiuqingSong Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...content-model/roosterjs-content-model-editor/lib/editor/plugins/ContentModelEditPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export default class ContentModelEditPlugin implements EditorPlugin {

case PluginEventType.ContentChanged:
case PluginEventType.MouseUp:
case PluginEventType.SelectionChanged:
this.editor.cacheContentModel(null);
break;
}
Expand Down
12 changes: 12 additions & 0 deletions ...nt-model/roosterjs-content-model-editor/test/editor/plugins/ContentModelEditPluginTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,18 @@ describe('ContentModelEditPlugin', () => {
);
expect(cacheContentModel).not.toHaveBeenCalled();
});

it('SelectionChanged event should clear cached model', () => {
const plugin = new ContentModelEditPlugin();

plugin.initialize(editor);
plugin.onPluginEvent({
eventType: PluginEventType.SelectionChanged,
selectionRangeEx: null!,
});

expect(cacheContentModel).toHaveBeenCalledWith(null);
});
});

describe('onPluginEvent, no need to go through Content Model', () => {
Expand Down