Fix Cell resizers and Table Inserters #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…u/acampostams/fix-resizers-and-inserters
This was referenced Aug 1, 2023
JiuqingSong
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Implementation of #1984 for the Table Inserters and Cell resizers
The Table Inserter and cell resizers are currently inserted on the document, thus putting them on a different container to the table they belong to. This creates issues in some scenarios such as when a dialog is created above the document with a high z-index. They also have a fixed position which causes issues in some scrolling scenarios, where they stayed fixed in place instead of moving or disappearing.
Fix
Changed the insertion point of where the resizers and inserters are located, inserted to where the Plugin specifies, if no selector is given it will default to the previous behaviour. The intent is for the selector to contain the editor. Additionally fixed a scenario here cells next to merged vertical cells could not be resized. This was due to there being a hover offset for the Inserter, but that was wrongly applied to every cell, not just the first column and row.