Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated colors from borders, text and background. #2045

Merged
merged 6 commits into from
Aug 29, 2023

Conversation

BryanValverdeU
Copy link
Contributor

@BryanValverdeU BryanValverdeU commented Aug 25, 2023

Win32 desktop apps add borders to tables like: 1pt solid windowtext, window text color is not supported. So remove those styles on paste

Added before and after here:
https://outlookweb.visualstudio.com/Outlook%20Web/_workitems/edit/220620/

Also, remove the deprecated colors using the textColorFormatHandler.parse and backgroundColorFormatHandler.parse

@JiuqingSong
Copy link
Collaborator

Actually, I think we also need to filter out unsupported colors in regular content model parsing process, but not only paste.

You can apply this process to

  • textColorFormatHandler.parse
  • backgroundColorFormatHandler.parse

And consider the perf impact, we don't want always extract the border info when parse, so you can keep doing this for border only when paste.

Then this change can also fix https://outlookweb.visualstudio.com/Outlook%20Web/_queries/edit/209841/?triage=true

@BryanValverdeU
Copy link
Contributor Author

Actually, I think we also need to filter out unsupported colors in regular content model parsing process, but not only paste.

You can apply this process to

  • textColorFormatHandler.parse
  • backgroundColorFormatHandler.parse

And consider the perf impact, we don't want always extract the border info when parse, so you can keep doing this for border only when paste.

Then this change can also fix https://outlookweb.visualstudio.com/Outlook%20Web/_queries/edit/209841/?triage=true

Sounds good, added support to remove these styles to those functions.

@BryanValverdeU BryanValverdeU changed the title Remove deprecated colors from borders Remove deprecated colors from borders, text and background color Aug 29, 2023
@BryanValverdeU BryanValverdeU changed the title Remove deprecated colors from borders, text and background color Remove deprecated colors from borders, text and background. Aug 29, 2023
@BryanValverdeU BryanValverdeU merged commit 0439b5a into master Aug 29, 2023
@JiuqingSong JiuqingSong deleted the u/bvalverde/deprecateBorderColors branch September 8, 2023 22:34
ianeli1 added a commit that referenced this pull request Sep 11, 2023
* Content Model: Improve cache behavior (#1999)

* Content Model: Improve cache behavior

* fix build

* fix comment

* Skip Trigger plugin event on plain text paste (#2011)

* init

* remove unneeded change

* Update return type

* Fix 218869: Do not allow dragging on readonly content (#2010)

* Fix 218869: Do not allow dragging readonly content

* fix test

* Content Model: Fix 194024 and 220289 (#2012)

* Content Model: Fix 221290 Support float for image (#2013)

* Content Model: improve formatWithContentModel 1 (#2001)

* Content Model: Improve cache behavior

* fix build

* Content Model: improve formatWithContentModel

* Content Model: improve formatWithContentModel 2 (#2002)

* Content Model: Improve cache behavior

* fix build

* Content Model: improve formatWithContentModel

* Content Model: improve formatWithContentModel 2

* fix format

* WIP

* fix handles

* MergeModel, do not inherit the styles of table when splitting the param (#2016)

* init

* init

* address comment

* update test names

* fixes

* Demo site: Fix insert link button in Content Model ribbon (#2018)

* Content Model: insertEntity API (#1800)

* Content Model insertEntity

* improve

* improve

* Content Model: Improve cache behavior

* fix build

* Content Model: improve formatWithContentModel

* Content Model: improve formatWithContentModel 2

* Improve

* fix build

* fix build

* improve

* add test

* add test

* add test

* add test

* fix dark color

* fix test

* fix build and test

* crop

* fix xase

* check cell exist

* Fix #1752, rename header to heading (#2020)

* fix cell empty cells

* fix flipped image

* Update logic to decide if we need to merge a table on paste. (#2022)

* Fix TableSelectionCopy

* update unit tests

* Fix 2

* address comment

* Content Model: Rename a test file (#2029)

* Fix Triple clicking a single cell selecting more than one (#2024)

* fix triple click, optimisation

* Remove `display: flex` style on paste (#2031)

* init

* Fix

* Replace first cell content if input while on cell selection (#2030)

* select first cell content and empty, add undo if change

* Content Model: Fix 222135 (#2035)

* Fix 222135

* fix build

* Content Model: Fix 219312 (#2036)

* Fix regression when creating the BeforePasteEvent (#2039)

* init

* fix build

* Content Model: Fix 220050 (#2037)

* Content Model: Fix 220050

* Fix build

* improve

* improve

* Simplify the domToModel call in `paste.ts` (#2040)

* add more changes

* fix build

* fix test

* Content Model: Support vertical-align for image (#2041)

* Content Model: Support vertical-align for image

* fix build and test

---------

Co-authored-by: Bryan Valverde U <[email protected]>

* Remove deprecated colors from borders, text and background. (#2045)

* Support more border styles

* init

* Revert  unrelated change

* Fix dependencies

* address comments

* try fix build

* reselection

* add space

* Content Model: Improve insertEntity (#2047)

* Content Model: Improve insertEntity

* fix test

* Content Model: Fix selection of entity (#2051)

* Content Model: Always return size in pt when getFormatState (#2052)

* Content Model: trigger ShadowEdit events (#2053)

* Content Model: trigger ShadowEdit events

* improve

* Content Model: Add solid paragraph in new table cell (#2055)

* Content Model: Do color transform for entity when copy/paste (#2056)

* Content Model: Do color transform for entity when copy/paste

* Call normalizeContentModel

* Content Model: Paste plain text applies current format (#2057)

* Content Model: Paste plain text applies current format

* fix build

* Content Model: Fix a regression of shadow edit (#2058)

* Update versions

* Fix double import

* Double import 2

---------

Co-authored-by: Jiuqing Song <[email protected]>
Co-authored-by: Bryan Valverde U <[email protected]>
Co-authored-by: Júlia Roldi <[email protected]>
Co-authored-by: Julia Roldi <[email protected]>
Co-authored-by: Andres-CT98 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants