[FHL] Deprecate AutoFormatList experimental feature #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
changed the title
juliaroldi
requested review from
JiuqingSong,
ianeli1,
flyingbee2012,
BryanValverdeU,
vinguyen12 and
Andres-CT98
and removed request for
JiuqingSong
JiuqingSong
reviewed
Sep 11, 2023
| @@ -144,6 +144,7 @@ export const enum ExperimentalFeatures { | |||
| TabKeyTextFeatures = 'TabKeyTextFeatures', | |||
|
|
|||
| /** | |||
| * @deprecated This feature is always enabled | |||
There was a problem hiding this comment.
Please move it up before line 139 to put this feature flag together with other deprecated ones.
packages/roosterjs-editor-plugins/lib/plugins/ContentEdit/features/listFeatures.ts
Show resolved
Hide resolved
JiuqingSong
reviewed
Sep 11, 2023
| true /*canUndoByBackspace*/ | ||
| ); | ||
| }, | ||
| shouldHandleEvent: (event, editor) => {}, |
There was a problem hiding this comment.
Not sure if this can pass the build. If not, just let it return false.
JiuqingSong
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated the
AutoFormatListexperimental feature and always enableAutoFormatListfeature. Also always the disableAutoBulletcontent edit feature.