Paste/Insert Image according to the visible viewport #2126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaroldi
requested review from
JiuqingSong,
BryanValverdeU,
flyingbee2012,
ianeli1,
vinguyen12 and
Andres-CT98
JiuqingSong
reviewed
Oct 5, 2023
| /** | ||
| * Images inserted in the editor that needs to have their size adjusted | ||
| */ | ||
| readonly images?: ContentModelImage[]; |
There was a problem hiding this comment.
Can we make it required?
| @@ -130,3 +132,16 @@ function handleDeletedEntities( | |||
| } | |||
| ); | |||
| } | |||
|
|
|||
| function handleImages(editor: IContentModelEditor, context: FormatWithContentModelContext) { | |||
| const viewport = editor.getVisibleViewport(); | |||
There was a problem hiding this comment.
Move this line inside "if" since we don't need it if there is no image
|
|
||
| function handleImages(editor: IContentModelEditor, context: FormatWithContentModelContext) { | ||
| const viewport = editor.getVisibleViewport(); | ||
| if (viewport && context.images) { |
There was a problem hiding this comment.
Also check images.length > 0.
For empty array, no need to do anything
| const viewport = editor.getVisibleViewport(); | ||
| if (viewport && context.images) { | ||
| const { top, bottom, left, right } = viewport; | ||
| const maxWidth = right - left; |
There was a problem hiding this comment.
Better have a minimum value such as 10, to avoid it to be 0 or negitve number
There was a problem hiding this comment.
const minMaxImageSize = 10;
maxWidth = Math.max(right-left, minMaxImageSize)
JiuqingSong
reviewed
Oct 6, 2023
| /** | ||
| * Images inserted in the editor that needs to have their size adjusted | ||
| */ | ||
| readonly images: ContentModelImage[]; |
There was a problem hiding this comment.
Suggest name it "newImages". Because we don't put existing images into it.
JiuqingSong
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When insert or paste image, add max height/width to the image, so large images can be resized to the size of the editor.
