Trigger apply changed when mouse up #2133
Conversation
juliaroldi
requested review from
JiuqingSong,
Andres-CT98,
flyingbee2012,
BryanValverdeU and
ianeli1
and removed request for
JiuqingSong
| @@ -179,6 +180,11 @@ export default class ImageEdit implements EditorPlugin { | |||
| e.preventDefault(); | |||
| } | |||
| }, | |||
| mouseup: e => { | |||
There was a problem hiding this comment.
we already have mouse up event handler at line 185
There was a problem hiding this comment.
The handler in the switch case is not triggered when the mouse up event happens in the image wrapper.
There was a problem hiding this comment.
I see. In that case, we should only attach this event handler when image wrapper is showing, and detach it when hide.
Also please try if we can attach the event to the wrapper element only, but not the whole window.
There was a problem hiding this comment.
Unless the user always have the cursor on the handles during the whole rotate and resize process, the event will not be triggered. Sometimes the cursor can move out from the handles.
There was a problem hiding this comment.
Try pass true as the 3rd parameter when addEventListener, see if that can fix this problem:
node.addEventListener('mouseup', handler, true /*useCapture*/);If that works, also need to pass true when remove event listener.
| @@ -57,6 +57,10 @@ export default function applyChange( | |||
| newSrc, | |||
| }); | |||
| newSrc = event.newSrc; | |||
| } else { | |||
There was a problem hiding this comment.
check the new parameter as well.
Added a new parameters
applyChangesOnMouseUp. If this parameter is true, when editing an image the last changes will be applied when mouse up event occurs.applyChangesOnMouseUpwill be false by default.